Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve #1061

Merged
merged 3 commits into from
Jun 28, 2017
Merged

docs: improve #1061

merged 3 commits into from
Jun 28, 2017

Conversation

luicfer
Copy link
Contributor

@luicfer luicfer commented Jun 15, 2017 •
edited
Loading

  • improve doc

@fengmk2
Copy link
Member

fengmk2 commented Jun 19, 2017

@luicfer commit author 改成 github 公开的

image

@fengmk2
Copy link
Member

fengmk2 commented Jun 20, 2017

ping @luicfer

@codecov
Copy link

codecov bot commented Jun 26, 2017 •
edited
Loading

Codecov Report

Merging #1061 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1061   +/-   ##
======================================
  Coverage    99.7%   99.7%           
======================================
  Files          29      29           
  Lines         676     676           
======================================
  Hits          674     674           
  Misses          2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4322212...08a81ff. Read the comment docs.

@luicfer luicfer force-pushed the feat/improve-doc branch from bbd6d3c to 34186c4 Compare June 27, 2017 08:04
@luicfer
Copy link
Contributor Author

luicfer commented Jun 27, 2017

尴尬。忘记改了

@luicfer
docs: improve
266ff0a 
去掉本地调试插件必须--save的说明，已经支持的插件的local配置
atian25
atian25 reviewed Jun 28, 2017
View reviewed changes
docs/source/zh-cn/advanced/plugin.md
@@ -414,8 +414,6 @@ module.exports = app => {
$ npm i egg-onerror --save
```

**注意：插件即使是只在 local 运行的，也需要配置为 dependencies 而不是 devDependencies，否则线上 `npm i --production` 时将无法找到插件。**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接干掉不妥，应该说只有配置在 local 的，才能 devdep。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里只是不用特别注明这句话了而已吧

@dead-horse dead-horse merged commit 0052351 into eggjs:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-horse dead-horse dead-horse approved these changes

@atian25 atian25 atian25 left review comments

@popomore popomore popomore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luicfer @fengmk2 @atian25 @popomore @dead-horse